RFR: JDK-8273959: Some metaspace diagnostic switches should be develop

Sat Sep 18 08:44:13 UTC 2021

May I have reviews please for this fix.

The switches `MetaspaceHandleDeallocations` and `MetaspaceGuardAllocations` control debug-only features and consequently should be develop instead.

Unnecessary usage of -XX:+UnlockDiagnosticVMOptions is removed (in two cases unrelated to the changed switches).

-------------

Commit messages:
 - JDK-8273959-Some-metaspace-diagnostic-switches-should-be-develop

Changes: https://git.openjdk.java.net/jdk/pull/5573/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5573&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273959
  Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5573.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5573/head:pull/5573

PR: https://git.openjdk.java.net/jdk/pull/5573