RFR: 8273695: Safepoint deadlock on VMOperation_lock [v2]

Robbin Ehn rehn at openjdk.java.net
Fri Sep 24 16:48:46 UTC 2021


On Wed, 22 Sep 2021 16:44:53 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8273695-swm-should-proc
>>  - Added update poll values and fixed PR comments
>>  - Removed string dedup test from problem list
>>  - Check SWS for processing
>
> src/hotspot/share/runtime/safepointMechanism.inline.hpp line 79:
> 
>> 77:   }
>> 78: 
>> 79:   // It have boiled down to two possibilities.
> 
> Please change to:
> // It has boiled down to two possibilities:

Fixed

> src/hotspot/share/runtime/safepointMechanism.inline.hpp line 82:
> 
>> 80:   // 1: We have nothing to process, this just a disarm poll.
>> 81:   // 2: We have a suspend handshake, which cannot be processed.
>> 82:   // We update the poll value in case of a disarm, to reduce false positive.
> 
> Typo: s/positive/positives/

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5613


More information about the hotspot-runtime-dev mailing list