RFR: 8273695: Safepoint deadlock on VMOperation_lock [v3]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Wed Sep 29 17:19:36 UTC 2021


On Wed, 29 Sep 2021 07:56:35 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/share/runtime/safepointMechanism.inline.hpp line 90:
>> 
>>> 88:   // 3: The JavaThread wakes-up from blocked and does not allow suspend.
>>> 89:   // We are now about to avoid processing and thus no cross modify fence will be executed.
>>> 90:   // Therefore we execute it here.
>> 
>> I would just say we still need to execute this fence in case a safepoint happened while being blocked, and not mention step 1 since as commented above there might be nothing to process.
>
> Updated, better?

Looks good, thanks for the update!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5613


More information about the hotspot-runtime-dev mailing list