RFR: JDK-8284178: os::commit_memory() should assert the given range [v3]

Thomas Stuefe stuefe at openjdk.java.net
Thu Apr 7 18:00:18 UTC 2022


> Trivial fix to assert that ranges given to os::commit/uncommit/release_memory are not empty.
> 
> I recently hunted an error where the memory reservation failed, was not handled, and the null pointer was accidentally passed to os::commit_memory(). The resulting `mmap()` failed and this looked like a commit error, when it really was a reservation error. An assert would have saved me time.

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  Aleksey feedback 2

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8075/files
  - new: https://git.openjdk.java.net/jdk/pull/8075/files/ff580166..2e3fadb6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8075&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8075&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8075.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8075/head:pull/8075

PR: https://git.openjdk.java.net/jdk/pull/8075


More information about the hotspot-runtime-dev mailing list