RFR: JDK-8284758: [linux] improve print_container_info [v3]

Matthias Baesken mbaesken at openjdk.java.net
Thu Apr 14 13:01:12 UTC 2022


On Thu, 14 Apr 2022 12:32:43 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   special handling of smaller numbers
>
> src/hotspot/os/linux/os_linux.cpp line 2260:
> 
>> 2258:   print_container_helper(st, OSContainer::memory_soft_limit_in_bytes(), "memory_soft_limit_in_bytes");
>> 2259:   print_container_helper(st, OSContainer::OSContainer::memory_usage_in_bytes(), "memory_usage_in_bytes");
>> 2260:   print_container_helper(st, OSContainer::OSContainer::memory_max_usage_in_bytes(), "memory_max_usage_in_bytes");
> 
> I guess this weirdness has been around since JDK-8146115, but can we clean this up to:
> 
> print_container_helper(st, OSContainer::memory_usage_in_bytes(), "memory_usage_in_bytes");
> print_container_helper(st, OSContainer::memory_max_usage_in_bytes(), "memory_max_usage_in_bytes");
> 
> 
> Up to you, though.

Hi Severin, I removed the "weirdness" (double OSContainer scope) at 4 places.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8217


More information about the hotspot-runtime-dev mailing list