RFR: 8213445: jcmd VM.symboltable and VM.stringtable -verbose output contains no shared symbols or strings [v3]

[Calvin Cheung]

On Wed, 20 Apr 2022 21:28:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use @build and ClassFileInstaller.writeJar for creating jar files for the tests under appcds/jcmd
>
> src/hotspot/share/classfile/stringTable.cpp line 657:
> 
>> 655: }
>> 656: 
>> 657: static void print_string(Thread* thr, outputStream* st, oop s) {
> 
> Nit: if `thr` is the current thread (has to be for the `ResourceMark`) then please call it `current`.

Fixed.

> src/hotspot/share/classfile/stringTable.cpp line 660:
> 
>> 658:   typeArrayOop value     = java_lang_String::value_no_keepalive(s);
>> 659:   int          length    = java_lang_String::length(s);
>> 660:   bool         is_latin1 = java_lang_String::is_latin1(s);
> 
> Nit: there is no need to align things this way.

I'll leave it this time since the code was factored out from existing code.

Thanks for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8234