RFR: JDK-8285362: unify os::pause platform coding

Matthias Baesken mbaesken at openjdk.java.net
Thu Apr 21 13:35:24 UTC 2022


On Thu, 21 Apr 2022 13:00:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This seems reasonable though I like to avoid ifdefs in the shared os code - but on the flip side we also like to avoid duplication. An alternative would be to keep the os_windows.cpp version and define a shared os_posix.cpp version instead ... but I guess I can live with this version.

Hi David, thanks for the review . Let's see what other think / prefer .

Best regards, Matthias

-------------

PR: https://git.openjdk.java.net/jdk/pull/8338


More information about the hotspot-runtime-dev mailing list