RFR: 8285279: ArgumentsTest.set_numeric_flag_double_vm fails on some locales (again)

David Holmes dholmes at openjdk.java.net
Tue Apr 26 00:12:52 UTC 2022


On Mon, 25 Apr 2022 23:53:14 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> test/hotspot/gtest/runtime/test_arguments.cpp line 599:
>> 
>>> 597:     errno = 0;
>>> 598:     double expected = strtod(str, &end);
>>> 599:     if (errno == 0 && end != NULL && *end == '\0') {
>> 
>> If end is not-empty shouldn't there be an `ASSERT_FALSE(ArgumentsTest::parse_argument(flag->name(), str)` ?
>
> Yes, that check is on line 609 below.

Sorry missed that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8386


More information about the hotspot-runtime-dev mailing list