RFR: JDK-8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory

David Holmes dholmes at openjdk.java.net
Thu Apr 28 05:56:41 UTC 2022


On Thu, 14 Apr 2022 08:36:26 GMT, Johan Sjölén <duke at openjdk.java.net> wrote:

> This PR replaces some of the VM `assert` with gtest `ASSERT` where applicable and fixes a bug in a UL test.
> The test used to create a temporary directory in cwd, failing if cwd is read-only. Now it creates the directory in /tmp/.

Hi Johan,

These changes all look fine. I initially missed the connection between the different files modified (in case you see my first comment).

Thanks,
David

Marked as reviewed by dholmes (Reviewer).

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8238


More information about the hotspot-runtime-dev mailing list