RFR: JDK-8285712: LogMessageBuffer doesn't check vsnprintf return value [v2]

Johan Sjölén duke at openjdk.java.net
Thu Apr 28 08:08:42 UTC 2022


On Thu, 28 Apr 2022 06:06:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move va_end to avoid duplication
>
> src/hotspot/share/logging/logMessageBuffer.cpp line 117:
> 
>> 115:     if (ret < 0) {
>> 116:       // Encoding error occurred, bail.
>> 117:       va_end(copy);
> 
> To avoid duplication I suggest moving the `va_end` to immediately after `os::vsnprintf`.

Thank you, fixed!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8423


More information about the hotspot-runtime-dev mailing list