RFR: JDK-8291558: unify print_jni_name_prefix_on and print_jni_name_suffix_on on posix platforms [v2]

Matthias Baesken mbaesken at openjdk.org
Mon Aug 1 07:10:57 UTC 2022


On Sun, 31 Jul 2022 21:58:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust comment
>
> src/hotspot/os/posix/os_posix.cpp line 605:
> 
>> 603: 
>> 604: void os::print_jni_name_prefix_on(outputStream* st, int args_size) {
>> 605:   // no prefix required, not even "_"
> 
> You could drop the "not even '_'" as there is no context to explain why we might have considered there is a need for it.

Hi David, thanks for the review !  I adjusted the comment.
I guess I can push this as trivial with 1 review ?

-------------

PR: https://git.openjdk.org/jdk/pull/9686


More information about the hotspot-runtime-dev mailing list