RFR: 8290370: Convert SymbolPropertyTable to Resource Hashtable [v2]

[Justin Gu]

On Thu, 21 Jul 2022 19:54:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Justin Gu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8290370: Convert InvokeMethodTable into Intrisic and Type table
>
> src/hotspot/share/classfile/systemDictionary.cpp line 2055:
> 
>> 2053:     ResourceMark rm;
>> 2054:     tty->print_cr("finding symbol %s %d", signature->as_C_string(), iid_as_int);
>> 2055:   }
> 
> You should remove this UseNewCode.

Removed

> src/hotspot/share/classfile/systemDictionary.cpp line 2204:
> 
>> 2202:   Handle empty;
>> 2203:   OopHandle* o;
>> 2204: 
> 
> Can you remove this extra blank line?

Yes

> src/hotspot/share/classfile/systemDictionary.cpp line 2277:
> 
>> 2275:     MutexLocker ml(THREAD, InvokeMethodTable_lock);
>> 2276:     bool created = false;
>> 2277:     assert(method_type != NULL, "THIS IS THE ERROR");
> 
> Change the string "THIS IS THE ERROR" (because it's not) to "unexpected null" or something like that.

Changed to unexpected null

-------------

PR: https://git.openjdk.org/jdk/pull/9495