RFR: JDK-8290370: Convert SymbolPropertyTable to Resource Hashtable [v2]

[Justin Gu]

On Thu, 21 Jul 2022 20:17:18 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Justin Gu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8290370: Convert InvokeMethodTable into Intrisic and Type table
>
> src/hotspot/share/classfile/systemDictionary.cpp line 92:
> 
>> 90: #endif
>> 91: 
>> 92: class InvokeMethodKey : public StackObj {
> 
> It is odd to declare as `StackObj`, should be value object instead.

I used the key as a StackObj in the code, it is implicitly copied into the hashtable, so technically it is a value object.  But since I explicitly used it as a StackObj I would like to keep it this way.

> src/hotspot/share/runtime/mutexLocker.cpp line 45:
> 
>> 43: Mutex*   CompiledMethod_lock          = NULL;
>> 44: Monitor* SystemDictionary_lock        = NULL;
>> 45: Mutex*   InvokeMethodTable_lock            = NULL;
> 
> Please align the value.

Fixed

> src/hotspot/share/runtime/mutexLocker.cpp line 265:
> 
>> 263: 
>> 264:   def(JmethodIdCreation_lock       , PaddedMutex  , nosafepoint-2); // used for creating jmethodIDs.
>> 265:   def(InvokeMethodTable_lock            , PaddedMutex  , safepoint);
> 
> Align the parameters

Fixed

> src/hotspot/share/runtime/mutexLocker.cpp line 324:
> 
>> 322:   def(ContinuationRelativize_lock  , PaddedMonitor, nosafepoint-3);
>> 323: 
>> 324: 
> 
> Extra empty line

Fixed

-------------

PR: https://git.openjdk.org/jdk/pull/9495