RFR: 8290833: Remove ConstantPoolCache::walk_entries_for_initialization() [v3]

[Coleen Phillimore]

On Tue, 9 Aug 2022 17:54:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use a separate _saved_cpcache_entries_table
>
> src/hotspot/share/oops/cpCache.cpp line 701:
> 
>> 699:   Arguments::assert_is_dumping_archive();
>> 700:   ConstantPoolCache* orig_cpc = ArchiveBuilder::current()->get_src_obj(this);
>> 701:   ConstantPoolCacheEntry* saved = SystemDictionaryShared::get_saved_cpcache_entries_locked(orig_cpc);
> 
> What does this do?  get_src_obj looks like it just returns the address with a cast to the type T.

I was confused with the template.  get_src_obj() gets in-memory (current) version of the metadata object.  It has a mapping to the copy in the archive. right?
"this" is the copy in the archive.  The comment helps.

-------------

PR: https://git.openjdk.org/jdk/pull/9759