RFR: JDK-8292071: NMT: move MallocHeader to its own header and inline header checks

Lutz Schmidt lucy at openjdk.org
Wed Aug 10 22:15:52 UTC 2022


On Tue, 9 Aug 2022 05:40:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> MallocHeader should be moved into its own header in preparation for further NMT changes.
> 
> Also, malloc header check routines - that are called on every free and realloc - should be inlined.
> 
> This is a plain code move. The classes were not changed, apart from making some of the functions inline, and fixing includes.

With the explanation given: LGTM.

I experimented with PR sequences to speed up work while keeping changes fine granular and easy to review.

I understand the motivation but don't really like the approach. It's basically mixing changes.

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9801


More information about the hotspot-runtime-dev mailing list