RFR: 8284313: Improve warning messages when CDS archive fails to load [v2]

[Calvin Cheung]

On Thu, 11 Aug 2022 05:52:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from David
>
> src/hotspot/share/cds/filemap.cpp line 468:
> 
>> 466:         log_warning(cds)("%s timestamp has changed.", name);
>> 467:       } else {
>> 468:         log_warning(cds)("%s size has changed.", name);
> 
> Shouldn't these be incorporated into the message the fail_continue will report under log_info? By themselves the log_warning output will look odd, with no context.

Thanks for the review. I've added the message from the fail_continue to the warning in case CDS logging is not enabled. Tests are also updated to look for the warning message.

-------------

PR: https://git.openjdk.org/jdk/pull/9823