RFR: 8284313: Improve warning messages when CDS archive fails to load [v2]

[Calvin Cheung]

On Fri, 12 Aug 2022 04:25:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from David
>
> src/hotspot/share/cds/filemap.cpp line 467:
> 
>> 465:       if (!log_is_enabled(Info, cds)) {
>> 466:         log_warning(cds)("A jar file is not the one used while building"
>> 467:             " the shared archive file: %s", name);
> 
> The string literal should be factored out and reused in both places.

Fixed.

> test/hotspot/jtreg/runtime/cds/appcds/WrongClasspath.java line 59:
> 
>> 57:     // should stil be there.
>> 58:     OutputAnalyzer output = TestCommon.execAuto(
>> 59:         /* "-cp", appJar, */ // <- uncomment this and the execution should succeed
> 
> Who is this comment intended for?

I've removed the comment.

-------------

PR: https://git.openjdk.org/jdk/pull/9823