RFR: 8284313: Improve warning messages when CDS archive fails to load [v3]
David Holmes
dholmes at openjdk.org
Fri Aug 12 06:52:25 UTC 2022
On Fri, 12 Aug 2022 06:21:21 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Please review this change for adding more helpful messages when a CDS archive has failed to load without CDS logging being enabled.
>>
>> e.g. warning for mismatch class paths between dump time and run time:
>> `[warning][cds] shared class paths mismatch (hint: enable -Xlog:class+path=info to diagnose the failure)`
>>
>> warning if a timestamp of a jar file has been changed during run time:
>> `[warning][cds] app.jar timestamp has changed.`
>>
>> Passed mach5 tiers 1,2,3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> more comments from David
Updates look good - thanks. One typo.
test/hotspot/jtreg/runtime/cds/appcds/WrongClasspath.java line 57:
> 55:
> 56: // Run with -Xshare:auto and without CDS logging enabled, the mismatch message
> 57: // should stil be there.
typo: stil
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9823
More information about the hotspot-runtime-dev
mailing list