RFR: JDK-8292072: NMT: repurpose Tracking overhead counter as global malloc counter [v2]

Thomas Stuefe stuefe at openjdk.org
Sat Aug 13 18:42:11 UTC 2022


On Sat, 13 Aug 2022 16:25:46 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Looks good from what I can tell. I've added two remarks - not sure whether they are meaningful.

Thanks a lot, Christoph!

> src/hotspot/share/services/mallocTracker.hpp line 159:
> 
>> 157:   // Total malloc invocation count
>> 158:   size_t total_count() const {
>> 159:     return _all_mallocs.count();
> 
> Is this correct style to implement the method in the header? Shouldn't it maybe be `inline`?

I think it is okay for oneliners. And "inline" is implied if the definition appears in the class body.

-------------

PR: https://git.openjdk.org/jdk/pull/9804


More information about the hotspot-runtime-dev mailing list