RFR: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.' [v2]
Coleen Phillimore
coleenp at openjdk.org
Wed Aug 17 14:04:38 UTC 2022
On Wed, 17 Aug 2022 13:44:35 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Please review this fix for JDK-8292054. The existing regression test for JDK-8285792, test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java, intermittently fails because it depends on periodic calls to JVM function os::run_periodic_checks(). This fix replaces test TestPosixSig.java with a gtest that does its own explicit call to os::run_periodic_checks().
>>
>> The fix was tested by running the new test 150+ times on Linux, Mac OS, and Windows.
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>
> Improve gtest based on review comments
test/hotspot/gtest/runtime/test_signals.cpp line 71:
> 69: modified = strstr(modified + 1, "Handler was modified!");
> 70: ASSERT_NE(modified, nullptr) << "Only one message found";
> 71: ASSERT_EQ(strstr(modified + 1, "Handler was modified!"), nullptr) << "Too many messages found";
Should this also assert that you only see one SIGFPE and one SIGILL handler once after both are modified ?
-------------
PR: https://git.openjdk.org/jdk/pull/9882
More information about the hotspot-runtime-dev
mailing list