RFR: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.' [v2]

[Thomas Stuefe]

On Wed, 17 Aug 2022 17:18:58 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> test/hotspot/gtest/runtime/test_signals.cpp line 71:
>> 
>>> 69:     modified = strstr(modified + 1, "Handler was modified!");
>>> 70:     ASSERT_NE(modified, nullptr) << "Only one message found";
>>> 71:     ASSERT_EQ(strstr(modified + 1, "Handler was modified!"), nullptr) << "Too many messages found";
>> 
>> This is nitpicking and feel free to disregard this. But maybe simpler to understand would be to scan that "Signal Handlers:" (the header line) appears just once, and maybe that "Warning: SIGFPE handler modified!" and "Warning: SIGILL handler modified!" appear just once too.
>
> Searching for "Warning: <signal> ..." output would not work because even in the bogus duplicate output, the "Warning ..." text only appears once per signal.  Searching for header line "Signal Handlers:" would work if you think that an additional search besides "Handler was modified" is needed.

Okay, sure. My concern was that this is difficult to understand. But people can read the JBS text to understand what's parsed.

-------------

PR: https://git.openjdk.org/jdk/pull/9882