RFR: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.' [v3]

[Harold Seigel]

On Wed, 17 Aug 2022 17:15:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test changes based on review comments
>
> test/hotspot/gtest/runtime/test_signals.cpp line 51:
> 
>> 49:     act.sa_flags = 0;
>> 50:     ASSERT_NE(sigaction(SIGFPE, &act, &old_SIGFPE_act), -1) << "Setting SIGFPE handler failed (errno)";
>> 51:     ASSERT_NE(sigaction(SIGILL, &act, &old_SIGILL_act), -1) << "Setting SIGILL handler failed (errno)";
> 
> Does that actually work? I would have thought that just prints the literal "errno". I meant something like this:
> 
> https://github.com/openjdk/jdk/blob/081c89316a2f35cad0a5dcc93e88707530e03d72/test/hotspot/gtest/logging/logTestUtils.inline.hpp#L56

That was rather stupid of me.  Commit 4 contains your suggested errno change.

-------------

PR: https://git.openjdk.org/jdk/pull/9882