RFR: 8292083: Detected container memory limit may exceed physical machine memory [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Aug 18 09:51:19 UTC 2022
On Thu, 18 Aug 2022 09:26:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> @jerboaa I don't sorry. My involvement with the container support was only peripheral.
>
> Looking at the [original changeset](https://hg.openjdk.java.net/jdk/jdk/rev/7f22774a5f42#l11.30) for this it appears the only reason for it is to account for `-XX:+AggressiveHeap` and setting related flags. As to why the hook in `os::physical_memory()` isn't sufficient I'm at a loss. The original review here https://mail.openjdk.org/pipermail/hotspot-dev/2017-October/028635.html suggests that there was supposed to be some support for interleaving os initialization and arguments processing, but I don't see it. To be safe, I'd just leave this as it is for this patch and potentially clean this up as a separate bug. Thoughts?
Okay. Maybe something for a follow-up RFE.
-------------
PR: https://git.openjdk.org/jdk/pull/9880
More information about the hotspot-runtime-dev
mailing list