RFR: 8292608: [AIX] Broken build after 8291945

Aleksey Shipilev shade at openjdk.org
Thu Aug 18 18:03:30 UTC 2022


On Thu, 18 Aug 2022 17:46:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Improvements to the os class for AIX contained a minor bug.
>> 
>> 
>> - _page_sizes.add(AIX::_page_size);
>> + _page_sizes.add(os::vm_page_size);
>> 
>> 
>> `AIX::_page_size` is an `int`, but `os::vm_page_size` is a `() -> int`. Adding the parens (changing vm_page_size to a function call) does the trick.
>
> Looks fine and trivial.

> @shipilev As I understand it, we usually wait for 2 reviewers. In this case, since the changes are trivial, can I assume that I may go ahead and merge without waiting for a second reviewer? Either way, I'll wait for the integration tests to complete.

Triviality rule. Notice I said "...and trivial" :)

For trivial patches, 1 reviewer is enough, and the patch is good for immediate integration. In addtition in this case, since the change is in AIX-specific file, and there are no AIX builds in GHA, there is no need to wait for integration tests to complete.

-------------

PR: https://git.openjdk.org/jdk/pull/9922


More information about the hotspot-runtime-dev mailing list