RFR: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized

David Holmes dholmes at openjdk.org
Fri Aug 19 01:30:29 UTC 2022


On Thu, 18 Aug 2022 19:56:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Plrease review this trivial PR:
> 
> The self-diagnostic test in CDS is too strict. `AccessFlag$Location::EMPTY_SET` is the same archived object as `ImmutableCollections::EMPTY_SET`, so at runtime we can guarantee the object equality of these two static fields.
> 
> This PR fixes the immediate problem, so that with `java -Xshare:dump` you won't see spurious warning messages. I am working on a more comprehensive fix in [JDK-8292635](https://bugs.openjdk.org/browse/JDK-8292635)

I can't say I understand the underlying issue that CDSHeapVerifier deals with, but adding this additional exclusion seems fine and trivial.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9926


More information about the hotspot-runtime-dev mailing list