RFR: 8291969: Convert LoaderConstraintsTable to ResourceHashtable [v2]

[Coleen Phillimore]

On Fri, 19 Aug 2022 03:24:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix include for minimal build.
>
> src/hotspot/share/classfile/loaderConstraints.cpp line 73:
> 
>> 71: 
>> 72:   // convenience
>> 73:   void set_loader(oop p) {
> 
> This should be `add_loader` not `set_loader`.

Ok.

> src/hotspot/share/classfile/loaderConstraints.cpp line 78:
> 
>> 76: };
>> 77: 
>> 78: class LoaderConstraintEntry : public StackObj {      // copied into hashtable as value
> 
> StackObj does not seem appropriate for something being stored in a hashtable.

Yes, I'd been using StackObj for the copy to put into the resource hashtable, removed.

> src/hotspot/share/classfile/loaderConstraints.cpp line 162:
> 
>> 160: 
>> 161:   // The klass may be null if it hasn't been loaded yet, for instance while checking
>> 162:   // an parameter name to a method call.  We impose this constraint that the
> 
> typo: s/an/a/
> 
> s/this/the/

fixed.

> src/hotspot/share/classfile/loaderConstraints.cpp line 163:
> 
>> 161:   // The klass may be null if it hasn't been loaded yet, for instance while checking
>> 162:   // an parameter name to a method call.  We impose this constraint that the
>> 163:   // class that is eventually loaded much match between these two loaders.
> 
> typo: s/much/must/

fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/9904