RFR: 8291969: Convert LoaderConstraintsTable to ResourceHashtable [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Aug 19 13:39:45 UTC 2022


On Fri, 19 Aug 2022 13:35:40 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This converts the LoaderConstraintTable to ResourceHashtable.  It's a bit different than the other conversions in that the LoaderConstraintEntry has to be restructured to hold all the loader constraints for that class name, since the search key is the class name.  Also, I replaced the raw arrays with GrowableArray, because it's less code.
>> Tested with tier1-3, and tier 4-7 previously with other changes.  I also verified code paths with some temporary asserts with existing tests, including jck tests.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code review comments and suggestions.

I can't preserve the existing logic because entries are merged and added.  This is much cleaner than what we had and works better as a hashtable.  The alternative is to make the old LoaderConstraintEntry a hash set, since you need the entire entry to do the search. The similar names are only found in the cpp file now.  I can make them less similar.  Sorry for the size of this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/9904


More information about the hotspot-runtime-dev mailing list