RFR: 8291969: Convert LoaderConstraintsTable to ResourceHashtable [v4]
Coleen Phillimore
coleenp at openjdk.org
Mon Aug 22 14:27:30 UTC 2022
On Mon, 22 Aug 2022 12:13:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/classfile/loaderConstraints.cpp line 79:
>>
>>> 77:
>>> 78: // For this class name, these are the LoaderConstraints for classes loaded with this name.
>>> 79: class ClassNameEntry { // copied into hashtable as value
>>
>> I find the naming for these map/table entries very awkward in general. A Map is a mapping from keytype K to a value type V. Here K == Symbol* (a class name), and V == a set of LoaderConstraints
>
> I was trying to not repeat "LoaderConstraint" in the name of the hashtable entry of LoaderConstraints, because that's what made it look confusing (especially in the diff).
> SetOfLoaderConstraints or LoaderConstraintSet. Maybe ClassNameEntry is a terrible name. I'm open for suggestions.
How about ConstraintSet ?
-------------
PR: https://git.openjdk.org/jdk/pull/9904
More information about the hotspot-runtime-dev
mailing list