RFR: 8292083: Detected container memory limit may exceed physical machine memory [v8]

Jonathan Dowland jdowland at openjdk.org
Mon Aug 22 16:09:53 UTC 2022


On Mon, 22 Aug 2022 15:11:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove cgroup sanity checking logic from os::Linux::available_memory
>>   
>>   and rely upon it from os::physical_memory instead.
>
> test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java line 112:
> 
>> 110:         // first run: establish physical memory in test environment and derive
>> 111:         // a bad value one power of ten larger
>> 112:         String goodMem = Common.run(opts).firstMatch("total physical memory: (\\d+)", 1);
> 
> `goodMem` will return `null` if there is no match. Could you please handle this and bail out the test with some meaningful message. Right now this fails the test run on unpatched with `--memory null0` being an illegal value when passed to the container engine.

Thanks, resolved in 4984ddd9c9f68c00aaa8935769e9ac925690c2fb.

-------------

PR: https://git.openjdk.org/jdk/pull/9880


More information about the hotspot-runtime-dev mailing list