RFR: 8292083: Detected container memory limit may exceed physical machine memory [v13]

[Jonathan Dowland]

> We discovered some systems configured with cgroups v1 which report a bogus container memory limit value which is above the physical memory of the host. OpenJDK then calculates flags such as InitialHeapSize based on this invalid value; this can be larger than the available memory which can result in the OS terminating the process due to OOM.
> 
> hotspot's container awareness attempts to sanity check the limit value by ensuring it's below `_unlimited_memory = (LONG_MAX / os::vm_page_size()) * os::vm_page_size()`, but that still leaves a large range of potential invalid values between physical RAM and that ceiling value.
> 
> Cgroups V1 in particular returns an uninitialised value for the memory limit when one has not been explicitly set. Cgroups v2 does not suffer the same problem: however, it's possible for any value to be set for the max memory, including values exceeding the available physical memory, in either v1 or v2.
> 
> This fixes the problem in two places. Further work may be required in the area of Java metrics / MXBeans. I'd also look again at whether the existing ceiling value `_unlimited_memory` serves any useful purpose. I personally don't feel those improvements should hold up this fix.

Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:

  Avoid memory_usage_in_bytes when unconstrained
  
  Thanks to Severin for the suggestion. When there is no memory limit
  in place, avoid calling OSContainer::memory_usage_in_bytes, instead
  preferring the non-container sysinfo approach.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9880/files
  - new: https://git.openjdk.org/jdk/pull/9880/files/4984ddd9..60865050

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9880&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9880&range=11-12

  Stats: 14 lines in 1 file changed: 6 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/9880.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9880/head:pull/9880

PR: https://git.openjdk.org/jdk/pull/9880