RFR: 8292083: Detected container memory limit may exceed physical machine memory [v15]

Jonathan Dowland jdowland at openjdk.org
Tue Aug 23 13:28:34 UTC 2022


On Tue, 23 Aug 2022 12:47:31 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove superfluous log line from os::Linux::available_memory
>>   
>>   Now that os::Linux::available_memory calls
>>   OSContainer::memory_limit_in_bytes,  we can remove a log_debug
>>   that replicates the logging that takes place there.
>
> src/hotspot/os/linux/os_linux.cpp line 227:
> 
>> 225:     }
>> 226:     log_debug(os, container)("container memory limit %s: " JLONG_FORMAT ", using host value",
>> 227:                             mem_limit == OSCONTAINER_ERROR ? "failed" : "unlimited", mem_limit);
> 
> It seems the equivalent line in `os::Linux::available_memory()` can get removed too, as we now log this info as part of `OSContainer::memory_limit_in_bytes()`

Thanks, done in 40930a81b6a.

-------------

PR: https://git.openjdk.org/jdk/pull/9880


More information about the hotspot-runtime-dev mailing list