RFR: JDK-8291878: NMT: Malloc limits [v2]

Thomas Stuefe stuefe at openjdk.org
Tue Aug 23 19:21:02 UTC 2022


On Tue, 23 Aug 2022 16:15:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/runtime/NMT/MallocLimitTest.java
>>    
>>    Co-authored-by: Aleksey Shipilëv <shade at redhat.com>
>>  - Update src/hotspot/share/runtime/globals.hpp
>>    
>>    Co-authored-by: Aleksey Shipilëv <shade at redhat.com>
>>  - Update src/hotspot/share/runtime/arguments.cpp
>>    
>>    Co-authored-by: Aleksey Shipilëv <shade at redhat.com>
>>  - Update src/hotspot/share/runtime/arguments.cpp
>>    
>>    Co-authored-by: Aleksey Shipilëv <shade at redhat.com>
>
> src/hotspot/share/runtime/arguments.cpp line 4450:
> 
>> 4448: //    it will return all found limits in the limits array.
>> 4449: // 4) If option is malformed, it will exit the VM.
>> 4450: // For (2) and (3), limits not affected by the switch will be set to 0.
> 
> This duplicates the comment at declaration, do you really need two copies?

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/9891


More information about the hotspot-runtime-dev mailing list