RFR: 8292083: Detected container memory limit may exceed physical machine memory [v17]

[Jonathan Dowland]

On Tue, 23 Aug 2022 14:34:56 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   avoid calling OSContainer::memory_usage_in_bytes
>>   
>>   if mem_limit isn't set, avoid calling OSContainer::memory_usage_in_bytes
>
> test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java line 122:
> 
>> 120:             .addDockerOpts("--memory", badMem);
>> 121:         Common.run(opts)
>> 122:             .shouldMatch("container memory limit ignored: "+badMem+", using host value "+goodMem);
> 
> Test now fails with:
> 
> java.lang.RuntimeException: 'container memory limit ignored: 332580331520, using host value 33258033152' missing from stdout/stderr
> 
> 
> Log lines on cg1 look like:
> 
> [0.065s][debug][os,container] container memory limit unlimited: -1, using host value 33258033152
> 
> 
> So it should be made more lenient to what it expects. For example:
> 
> 
>         Common.run(opts)
>             .shouldMatch("container memory limit (ignored|unlimited): (-1|" + badMem + "), using host value " + goodMem);

Ah thank you, I had only re-run it on v2. Addressed in bd24938d163.

-------------

PR: https://git.openjdk.org/jdk/pull/9880