RFR: 8292083: Detected container memory limit may exceed physical machine memory [v18]

Jonathan Dowland jdowland at openjdk.org
Wed Aug 24 10:35:21 UTC 2022


On Wed, 24 Aug 2022 09:37:37 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Looks good to me. Please get a second review for this, though, if you can.

Thanks @jerboaa much appreciated.

@tstuefe, you provided some valuable feedback on this PR in an earlier incarnation. Would you be prepared to take another look?

> test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java line 122:
> 
>> 120:             .addDockerOpts("--memory", badMem);
>> 121:         Common.run(opts)
>> 122:             .shouldMatch("container memory limit (ignored: "+badMem+"|unlimited: -1), using host value " + goodMem);
> 
> Style nit: Space before and after `+`: `... (ignored: " + badMem + "|unlimited: ...`

Fixed in af509e15235

-------------

PR: https://git.openjdk.org/jdk/pull/9880


More information about the hotspot-runtime-dev mailing list