RFR: 8291736: find_method_handle_intrinsic leaks Method*

[Ioi Lam]

On Tue, 23 Aug 2022 15:29:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> As part of the SymbolPropertyTable conversion, we noticed that threads could race to add the Method entry to the table, and the loser wasn't deleted.  This change locks the InvokeMethodTable_lock through the Method creation so that it's not leaked.  See bug for details, but this was performance tested with our general suite of performance tests to show no significant differences.
> Also tested with tier1-3, and previously 4-7 with SymbolPropertyTable conversion patch.

This looks fine. Now we are holding a lock across the call to `make_method_handle_intrinsic`, but that doesn't seem to do anything complicated (luckily it's not calling back into Java), so we should be OK.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9983