RFR: 8291736: find_method_handle_intrinsic leaks Method* [v2]

[Coleen Phillimore]

On Thu, 25 Aug 2022 00:08:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 2073:
> 
>> 2071:          "must be a known MH intrinsic iid=%d: %s", iid_as_int, vmIntrinsics::name_at(iid));
>> 2072: 
>> 2073:   MutexLocker ml(THREAD, InvokeMethodTable_lock);
> 
> I don't think you can hold the Mutex across the entire method as the exception code below will go to Java.

This call does not go to Java.  The other table does - the invoke_method_type_table.  This just creates an intrinsic method and an adapter to go with it from the AdapterHandlerLibrary.

> src/hotspot/share/classfile/systemDictionary.cpp line 2077:
> 
>> 2075:   Method** met = _invoke_method_intrinsic_table.get(key);
>> 2076:   if (met != nullptr) {
>> 2077:    return *met;
> 
> Indent appears off

fixed

-------------

PR: https://git.openjdk.org/jdk/pull/9983