RFR: 8292083: Detected container memory limit may exceed physical machine memory [v19]

Thomas Stuefe stuefe at openjdk.org
Thu Aug 25 18:17:15 UTC 2022


On Thu, 25 Aug 2022 17:51:39 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > I think the gist of my remark is that I would like the layers to behave consistently.
> > I see that `CgroupSubsystem::memory_limit_in_bytes()` is only used in two places, `os::Linux::available_memory() ` and `os::physical_memory`.
> 
> You mean `OSContainer::memory_limit_in_bytes()` right?

Right. 

> 
> > I would say let the `os` layer lie and `Linux` and `CgroupSystem` be the truth. Then we end up with a clear hierarchy:
> 
> There is also this `OSContainer` hybrid ;-)

Yes, that is what I meant with "CgroupSystem". Sorry, I collapsed that with its CGV1/V2 implementations for less confusion :)

-------------

PR: https://git.openjdk.org/jdk/pull/9880


More information about the hotspot-runtime-dev mailing list