RFR: 8292541: [Metrics] Reported memory limit may exceed physical machine memory [v5]

Jonathan Dowland jdowland at openjdk.org
Fri Aug 26 13:21:00 UTC 2022


On Thu, 25 Aug 2022 16:15:53 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> When the container memory exceeds the physical host's memory, the Java metrics reporting is wrong.
>> 
>> https://bugs.openjdk.org/browse/JDK-8292541
>> 
>> This is the equivalent core-libs fix for Hotspot's [JDK-8292083](https://bugs.openjdk.org/browse/JDK-8292083)
>> (https://github.com/openjdk/jdk/pull/9880)
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a log-line for total physical memory
>   
>   This is relied upon for tests in
>   test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java

Now that #9880 has been merged the hack is gone and the tests can match against the log lines to establish base line physical RAM. There are three tests that use this now. In [cc8fdf3](https://github.com/openjdk/jdk/pull/10017/commits/cc8fdf36af5e3f75c47348d25697e8a0b496dd42) for this PR I've adjusted the first test (merged already) to share the established baseline physical RAM value rather than calculate it again.

@jerboaa WDYT now? And thanks for all your support!

-------------

PR: https://git.openjdk.org/jdk/pull/10017


More information about the hotspot-runtime-dev mailing list