RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows enviromnent [v3]

[Naoto Sato]

On Fri, 26 Aug 2022 06:32:35 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I removed a section of via JDK_JAVA_OPTIONS because including main class is not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment variable. At this time, this test is mismatch with the specification.
>> I tried to test and get Passed on Japanese Windows environment.
>> Could you review this fix, please?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows

LGTM

test/jdk/tools/launcher/I18NArgTest.java line 104:

> 102:         // we expect that system property value to be passed along to the main method with the
> 103:         // correct encoding
> 104:         // If <unicodestr> contains space or tab, it should beenclosed with double quotes.

Nit: space is missing between "be" and "enclosed"

test/jdk/tools/launcher/I18NArgTest.java line 147:

> 145:             for (int i = 0; i < sysPropVal.length(); i++) {
> 146:                 sysPropHexVal = sysPropHexVal.concat(Integer.toHexString(sysPropVal.charAt(i)));
> 147:             }

It's OK as it stands, but this loop could be replaced with a `HexFormat` one-liner.

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9389