RFR: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag

[David Holmes]

On Mon, 29 Aug 2022 22:11:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial fix.
> 
> The function `FLAG_MEMBER_SETTER(name)` is no longer declared for non-product flags (`develop` or `notproduct`) in a product build. If you use use `FLAG_SET_XXX` with such a flag in a product build, you'd get a C++ compile error.
> 
> This is validated by the change in arguments.cpp, which used to set the `notproduct` flag `UseDebuggerErgo1` in product builds. Now this code must be put inside `#ifndef PRODUCT`

Hardly trivial as these macros are totally obscure to begin with :)

Where is the definition of what the arguments to ALL_FLAGS means? [Found it - allFlags.hpp]

It appears we have been handling develop and notproduct incorrectly.

Doesn't JVMFlagsEnum also need adjustment?

-------------

PR: https://git.openjdk.org/jdk/pull/10072