RFR: 8293046: Move CDS command-line flags to cds_globals.hpp

[David Holmes]

On Mon, 29 Aug 2022 22:59:03 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Flags like `VerifySharedSpaces`, `SharedBaseAddress`, `DumpLoadedClassList`, etc, should be moved from globals.hpp to a new file, src/hotspot/share/cds/cds_globals.hpp

What is the motivation here? With a separate header file we have to use INCLUDE_CDS on the `#include` line - but then we need to include macros.hpp prior to that. Seems messy. What does the separation buy us?

src/hotspot/share/classfile/classLoader.cpp line 28:

> 26: #include "jvm.h"
> 27: #include "jimage.hpp"
> 28: #include "cds/cds_globals.hpp"

Doesn't this, and similar, need to be guarded by INCLUDE_CDS?

-------------

PR: https://git.openjdk.org/jdk/pull/10073