Integrated: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
Ioi Lam
iklam at openjdk.org
Tue Aug 30 22:05:20 UTC 2022
On Mon, 29 Aug 2022 22:11:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The function `FLAG_MEMBER_SETTER(name)` is no longer declared for non-product flags (`develop` or `notproduct`) in a product build. If you use use `FLAG_SET_XXX` with such a flag in a product build, you'd get a C++ compile error.
>
> This is validated by the change in arguments.cpp, which used to set the `notproduct` flag `UseDebuggerErgo1` in product builds. Now this code must be put inside `#ifndef PRODUCT`
This pull request has now been integrated.
Changeset: 1cf245d7
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1cf245d77c0948b6f03025e80faa4517a6f79f3f
Stats: 13 lines in 2 files changed: 12 ins; 0 del; 1 mod
8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
Reviewed-by: dholmes, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/10072
More information about the hotspot-runtime-dev
mailing list