RFR: 8291736: find_method_handle_intrinsic leaks Method* [v3]

[David Holmes]

On Fri, 26 Aug 2022 12:49:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This is a subtle interaction that only you noticed.

You mean in this review?  The original code clearly knew this had to be done outside the lock:

http://hg.openjdk.java.net/jdk7/jdk7/hotspot/rev/e5b0439ef4ae#l33.106

Now perhaps the current code is actually safe (as @iklam suggests) because it can't actually invoke any Java code? But that is something we would need to establish. In any case it seems an anti-pattern to allow any kind of use of CHECK from inside a locked region when we "know" we always have to throw exceptions outside of locked regions.

-------------

PR: https://git.openjdk.org/jdk/pull/9983