RFR: 8297313: Refactor APIs for calculating address of CDS archive heap regions [v2]

Ioi Lam iklam at openjdk.org
Thu Dec 1 03:05:13 UTC 2022


On Wed, 30 Nov 2022 16:55:18 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - @calvinccheung comments
>>  - Merge branch 'master' into 8297313-refactor-cds-heap-region-address-apis
>>  - 8297313: Refactor APIs for calculating address of CDS archive heap regions
>
> src/hotspot/share/cds/archiveHeapLoader.hpp line 144:
> 
>> 142:   static bool      _mapped_heap_relocation_initialized;
>> 143: 
>> 144:   static void init_narrow_oop_decoding(address base, int shift) NOT_CDS_JAVA_HEAP_RETURN;
> 
> This is already inside the `#if INCLUDE_CDS_JAVA_HEAP` block. So the `NOT_CDS_JAVA_HEAP_RETURN` seems redundant.

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/11257


More information about the hotspot-runtime-dev mailing list