RFR: 8297718: Make NMT free:ing protocol more granular [v2]
Johan Sjölen
jsjolen at openjdk.org
Thu Dec 1 14:11:16 UTC 2022
On Mon, 28 Nov 2022 13:10:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with 10 additional commits since the last revision:
>>
>> - Add test that asserts block integrity after revival
>> - Make MallocHeader NONCOPYABLE
>> - Rest of it
>> - Adjust comments
>> - Put back comment, suitably rewritten
>> - Note reversibility of mark_block_as_dead
>> - Rename record_free_block to record_free
>> - Rename record_free to deaccount
>> - Move FreePackage into MallocHeader and rename
>> - Rename as revive, delete copy ctr
>
> src/hotspot/share/services/mallocHeader.hpp line 125:
>
>> 123:
>> 124: public:
>> 125: MallocHeader(const MallocHeader&) = default;
>
> This makes me a bit nervous, where do we copy malloc headers?
Thanks for the catch! It's not necessary, I replaced it with `NONCOPYABLE(MallocHeader)`.
-------------
PR: https://git.openjdk.org/jdk/pull/11390
More information about the hotspot-runtime-dev
mailing list