RFR: 8297606: [AIX] Broken build after JDK-8295475 [v2]
Tyler Steele
tsteele at openjdk.org
Thu Dec 1 18:33:05 UTC 2022
> Recent changes (https://github.com/openjdk/jdk/pull/10745) to ResourceObj, have caused the build to fail on AIX. This is because the AIX compiler (xlclang++) complains if 'operator new' is called on a class where 'operator delete' is marked as deleted (ie. `operator delete(void*) = delete`). This is the case even when 'operator new' is explicitly defined.
>
> It is my understanding that future PRs will migrate many instances of ResourceObj to AnyObj (or other classes), so it's possible this work-around could be removed in the future. An alternate solution is to change ResouceObj to AnyObj in 61 places. This alternative solution works since AnyObj defines both 'operator new' and 'operator delete'. This is both a much bigger change, and doesn't provide any additional benefit if instances of ResourceObj are being reviewed anyway.
Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Remove trailing whitespace
- Fix issue related to deleted functions in xlc
xlc complains about operator new useage when operator delete(...) = delete
- Added workaround for ResourceObj
- Added workaround for ArenaObj
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11443/files
- new: https://git.openjdk.org/jdk/pull/11443/files/17a4bbf0..1c34fc85
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11443&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11443&range=00-01
Stats: 55773 lines in 1035 files changed: 19600 ins; 23153 del; 13020 mod
Patch: https://git.openjdk.org/jdk/pull/11443.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11443/head:pull/11443
PR: https://git.openjdk.org/jdk/pull/11443
More information about the hotspot-runtime-dev
mailing list