RFR: JDK-8297958: NMT: Display peak values [v2]

Thomas Stuefe stuefe at openjdk.org
Tue Dec 6 06:36:05 UTC 2022


On Mon, 5 Dec 2022 20:06:08 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

> Important addition to the memory stats in my opinion. I agree having it in release build would be great.
> 
> > I omit printing peak values when we are at peak. So if "peak" is missing, current peak is implied.
> 
> It can be confusing for others not aware of this behavior, and may think that the "peak" value is missing in the output. I believe it would be less confusing if "peak" is "always" displayed.

Thank you, @ashu-mehra!

The first version had "(peak)" written after every line if at current peak. I found the output cluttered, but let's see what others say. I'm fine with reintroducing it again.

Cheers, Thomas

-------------

PR: https://git.openjdk.org/jdk/pull/11497


More information about the hotspot-runtime-dev mailing list