RFR: JDK-8297958: NMT: Display peak values [v2]

[Thomas Stuefe]

On Tue, 6 Dec 2022 12:11:18 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small fix
>
> src/hotspot/share/services/mallocTracker.hpp line 140:
> 
>> 138: 
>> 139:   const MemoryCounter* malloc_counter() const { return &_malloc; }
>> 140:   const MemoryCounter* arena_counter()  const { return &_arena;  }
> 
> It seems to me like we can keep these as returning references, if the printers take them in as references instead. Am I missing something?
> 
> I'm fine with keeping them as pointers, but I do want to make sure that I'm not missing some reasoning here.

(My first answer got lost somehow)

You understand correctly. I have a slight preference for pointers since one can tell them easier apart in coding, but ultimately just a coin toss here.

-------------

PR: https://git.openjdk.org/jdk/pull/11497