RFR: JDK-8298147: Clang warns about pointless comparisons

Thomas Stuefe stuefe at openjdk.org
Wed Dec 7 07:22:06 UTC 2022


On Wed, 7 Dec 2022 06:25:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

> These changes seem fine, but doesn't this then have a flow-on effect as these methods can themselves no longer return NULL?

Hi David,

thanks for looking. The GET_CONTAINER_INFO_CPTR themselves handle errors and return NULL:

https://github.com/openjdk/jdk/blob/95029a0597d3c0d7a6007889a110d13484c8d2df/src/hotspot/os/linux/cgroupSubsystem_linux.hpp#L168-L179

-------------

PR: https://git.openjdk.org/jdk/pull/11544


More information about the hotspot-runtime-dev mailing list