RFR: 8297718: Make NMT free:ing protocol more granular [v2]

David Holmes dholmes at openjdk.org
Thu Dec 8 22:11:26 UTC 2022


On Thu, 8 Dec 2022 09:50:15 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> We should try to use `nullptr` in new code and change from NULL within those methods for consistency, but a broader cleanup should be done as a separate cleanup RFE.
>
> My strategy for the `NULL` to `nullptr` conversion is that if I touch the line of code, I change it to `nullptr`. Changing whole methods lead to a larger diff for reviewers, which can be annoying when looking for the relevant changes.

Introducing inconsistency in surrounding code is not a good thing though. If you think it too distracting to do the entire method then I would suggest don't do it at all and just leave it all for a cleanup RFE.

-------------

PR: https://git.openjdk.org/jdk/pull/11390


More information about the hotspot-runtime-dev mailing list